fix: use portable shebang in native messaging host wrapper#45
Open
ppetru wants to merge 1 commit intonicobailon:mainfrom
Open
fix: use portable shebang in native messaging host wrapper#45ppetru wants to merge 1 commit intonicobailon:mainfrom
ppetru wants to merge 1 commit intonicobailon:mainfrom
Conversation
On NixOS (and other non-FHS Linux distributions like Guix), /bin/bash
doesn't exist — all binaries live in the Nix store.
This causes Chrome's native messaging to fail with:
LaunchProcess: failed to execvp:
/home/user/.local/share/surf-cli/host-wrapper.sh
The fix changes the generated shebang from #!/bin/bash to
#!/usr/bin/env bash, which is portable across all Unix-like systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On NixOS (and other non-FHS Linux distributions like Guix),
/bin/bashdoesn't exist — all binaries live in the Nix store.This causes Chrome's native messaging to fail with:
The fix changes the generated shebang from
#!/bin/bashto#!/usr/bin/env bash, which is portable across all Unix-like systems.